keywords changed
keywords3.2-early added Cool. (Not a problem, also. I killed the attachment.) Patch looks great, at a glance. All I see are coding standards improvements to be addressed. Marking for 3.2-early. foreach...
View ArticleArticle 4
Done, sorry about that. I can't see a way to remove the old .txt file (not that familiar with trac).
View ArticleArticle 2
Replying to djcp: I suppose you could do something stupid like enter "*.com" and allow anyone with a .com address to register in your multisite install, but c'mon. You can't fix stupid. :-) I like...
View Articlekeywords changed
keywordshas-patch added; needs-patch removed So if a limited domain begins with "*.", we nick off those characters and check it against the right side of the user's email domain. If a limited domain...
View Articlemilestone changed; keywords set
keywordsneeds-patch added milestone changed from Awaiting Review to Future Release Seems sensible. A patch would be great.
View Articlestatus changed; resolution set; milestone deleted
status changed from reviewing to closedresolution set to wontfixmilestoneFuture Release deleted This ticket has not seen any activity in over *two* years, so I'm closing it as "wontfix". The ticket may...
View Articlekeywords, status changed; milestone set; resolution deleted
keywordsbulk-reopened added status changed from closed to reopenedresolutionwontfix deleted milestone set to Awaiting Review A decision was made to reopen tickets that were closed in the bulk edit...
View Articlekeywords changed
keywordsneeds-patch added; has-patch removed Needs improved patch. See comment:38
View Articlekeywords, component changed; focuses set
keywordscommit removed focusesmultisite added component changed from Multisite to Login and Registration
View Articlemilestone changed
milestone changed from 3.7 to Future Release I started to break this down by removing is_email_address_allowed() all together, and using is_domain_in_list() directly in the validate signup function. I...
View ArticleArticle 47
I'm a fan of _whitelist and _blacklist. The change to is_domain_in_list() is appealing too.
View ArticleArticle 46
But I will note the option names are "limited" and "banned", not "allowed" and "unsafe". Ah right, I was misremembering. I guess I made up "allowed". The clearest terms to me are 'whitelist' and...
View ArticleArticle 45
I guess I don't quite see "allowed" and "unsafe" being parallel. Maybe I'm wrong? I guess "safe" would make more sense, but that's not good either because it isn't strictly an inverse. Maybe we go...
View ArticleArticle 44
What about is_domain_in_list() that is allowed to receive an email address? If @ exists, we explode on it, otherwise, we just assume the whole string is the email. I like that idea. See 15706.4.patch,...
View ArticleArticle 42
So I think the only objection I have to this is the function naming. is_email_domain_in_list() is okay, but not great. It receives a full email address, but its name suggests it is not just checking...
View Articlekeywords changed
keywordscommit added; dev-feedback removed I've asked westi to look this over.
View ArticleArticle 40
Patch works for me, tests come out as expected before and after patch, docs look good. I tweaked a little in 15706.3.diff to add @ticket annotations to the tests and remove one whitespace change that...
View Article