keywords changed
keywordsneeds-patch added; has-patch removed Needs improved patch. See comment:38
View Articlekeywords, component changed; focuses set
keywordscommit removed focusesmultisite added component changed from Multisite to Login and Registration
View Articlemilestone changed
milestone changed from 3.7 to Future Release I started to break this down by removing is_email_address_allowed() all together, and using is_domain_in_list() directly in the validate signup function. I...
View ArticleArticle 47
I'm a fan of _whitelist and _blacklist. The change to is_domain_in_list() is appealing too.
View ArticleArticle 46
But I will note the option names are "limited" and "banned", not "allowed" and "unsafe". Ah right, I was misremembering. I guess I made up "allowed". The clearest terms to me are 'whitelist' and...
View ArticleArticle 45
I guess I don't quite see "allowed" and "unsafe" being parallel. Maybe I'm wrong? I guess "safe" would make more sense, but that's not good either because it isn't strictly an inverse. Maybe we go...
View ArticleArticle 44
What about is_domain_in_list() that is allowed to receive an email address? If @ exists, we explode on it, otherwise, we just assume the whole string is the email. I like that idea. See 15706.4.patch,...
View ArticleArticle 42
So I think the only objection I have to this is the function naming. is_email_domain_in_list() is okay, but not great. It receives a full email address, but its name suggests it is not just checking...
View Articlekeywords changed
keywordscommit added; dev-feedback removed I've asked westi to look this over.
View ArticleArticle 40
Patch works for me, tests come out as expected before and after patch, docs look good. I tweaked a little in 15706.3.diff to add @ticket annotations to the tests and remove one whitespace change that...
View Articlekeywords changed
keywordsneeds-docs removed 15706.5.diff adds docs to the previous patch.
View ArticleArticle 33
15706.4.diff does a few things: Merges Boone's 2 patches into one for develop.svn Accounts for the changes in [25197] that added case insensitivity to the email check Removes unused local...
View Articlekeywords changed
keywordshas-patch added; needs-refresh removed 15706.3.patch is a refresh against trunk that does the following (some overlap with #21730): Introduces is_email_domain_in_list(), a utility function for...
View Articlekeywords changed
keywordsneeds-refresh added; has-patch removed Patch will need refreshing, because sanitization changes introduced in r21993 (#21552) mean that items containing asterisks are now stripped when the...
View ArticleArticle 22
Since "Banned Email Domains" field already supports regexps, wouldn't it make sense to do the same in "Limited Email Registrations" for consistency? Done in 15706.2.patch.
View Articlestatus, milestone changed; owner set
owner set to westistatus changed from new to reviewingmilestone changed from 3.3 to Future Release Tend to agree that a filter would be better. A filter on the response, that passes in the emaildomain....
View ArticleArticle 18
I still think a better solution here is a filter which allows for a plugin to implement this or any other rule for allowed domains rather than complicating the core code in this case. We should just...
View Articlekeywords changed
keywordsdev-feedback added We're at freeze for 3.3. Leads/committers, please weigh in on commit vs punt. As always an incremental improvement over the course of several releases is better than not...
View ArticleArticle 16
Replying to andrea_r: As an extra, anyway you could make the same in the DISallowed email field? So super admins can block all *.info or *.ru domains from signing up (for example)....
View Articlekeywords, milestone changed
keywords3.2-early removed milestone changed from Future Release to 3.3 Refreshed for 3.3, adjusted as per nacin's comments.
View ArticleArticle 13
I am a sad panda. This didn't make it into 3.2 beta 1, and I think this has real utility for academia and any large institution that wants to create easy to manage multisite installs. Any chance this...
View Articlecc changed
ccwesti added I wonder how many people use the limited email domains feature - didn't even realise it existed. I also wonder if this would not be better served by better hooks and a plugin?
View ArticleArticle 11
Replying to djcp: Replying to nacin: Cool. (Not a problem, also. I killed the attachment.) Patch looks great, at a glance. All I see are coding standards improvements to be addressed. Marking for...
View ArticleArticle 10
Replying to djcp: Replying to nacin: As this is my first contribution to the wordpress core, I'm a little unsure of standards. Sorry! Should I make those change and re-upload? Not a problem. Congrats...
View ArticleArticle 9
Replying to andrea_r: +1, yes please. As an extra, anyway you could make the same in the DISallowed email field? So super admins can block all *.info or *.ru domains from signing up (for example)....
View ArticleArticle 8
Replying to nacin: Cool. (Not a problem, also. I killed the attachment.) Patch looks great, at a glance. All I see are coding standards improvements to be addressed. Marking for 3.2-early. As this is...
View Articlecc changed
ccandrea_r added +1, yes please. As an extra, anyway you could make the same in the DISallowed email field? So super admins can block all *.info or *.ru domains from signing up (for example).
View Articlekeywords changed
keywords3.2-early added Cool. (Not a problem, also. I killed the attachment.) Patch looks great, at a glance. All I see are coding standards improvements to be addressed. Marking for 3.2-early. foreach...
View ArticleArticle 4
Done, sorry about that. I can't see a way to remove the old .txt file (not that familiar with trac).
View ArticleArticle 2
Replying to djcp: I suppose you could do something stupid like enter "*.com" and allow anyone with a .com address to register in your multisite install, but c'mon. You can't fix stupid. :-) I like...
View Articlekeywords changed
keywordshas-patch added; needs-patch removed So if a limited domain begins with "*.", we nick off those characters and check it against the right side of the user's email domain. If a limited domain...
View Articlemilestone changed; keywords set
keywordsneeds-patch added milestone changed from Awaiting Review to Future Release Seems sensible. A patch would be great.
View Article
